feat!: rename --define-process-env-node-env to --config-node-env
#4318
Conversation
snitin315
force-pushed
the
fix-define-process-env
branch
from
759901b
to
5544aaf
Compare
snitin315
changed the title
--node-env and `--define-process-env-n…--node-env and --define-process-env-node-env
snitin315
changed the title
--node-env and --define-process-env-node-env--node-env and --define-process-env-node-env
| } else if (typeof options.nodeEnv === "string") { | ||
| const isNodeEnvOptionDefined = typeof options.nodeEnv === "string"; | ||
| const isDefineProcessEnvNodeEnvOptionDefined = | ||
| typeof options.defineProcessEnvNodeEnv === "string"; |
There was a problem hiding this comment.
@snitin315 I don't think we need this option anymore anyway. We have - https://github.com/webpack/webpack/blob/main/lib/WebpackOptionsApply.js#L599.
The main problem is that we have two options:
--node-env(setprocess.env.NODE_ENVforwebpack.config.js)--optimization-node-env(setprocess.env.NODE_ENVfor runtime)
And that's why they confuse some developers. The names are almost the same, but they do completely different things.
I think the best solution would be to do the following:
- remove
--define-process-env-node-envat all - we leave
--node-envbecause it is widely used by many - we come up with a new name for the
--node-envvariable and updates the documentation so that new developers can use it
Shortly --node-env and ---new-name-node-env work and do the same thing, but the documentation will recommend to use a new name.
To be honest I have no ideas for a new name, so I'd be happy to hear any suggestions 😄
There was a problem hiding this comment.
@alexander-akait how about --config-node-env or --config-only-node-env?
There was a problem hiding this comment.
--config-node-env sounds good
snitin315
force-pushed
the
fix-define-process-env
branch
from
d34d6e3
to
1ee224c
Compare
snitin315
changed the title
--node-env and --define-process-env-node-env--define-process-env-node-env to --config-node-env
What kind of change does this PR introduce?
Fix #3503 (comment)
webpack-cli/packages/webpack-cli/src/webpack-cli.ts
Lines 2388 to 2390 in c97779b
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Will update in docs website, I have updated the option descriptions.
Summary
#4318 (comment)
Does this PR introduce a breaking change?
Yes
--define-process-env-node-envwas removed in favor of--config-node-envoption.Other information
No